Adjust grid_device for optimization #7693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Slightly optimize validation to avoid calling op.qubits several times. This also avoids an isinstance check. - Change instance GateFamily for cirq.I into a type GateFamily for IdentityGate which is faster and more general. - Also add ignore_global_phase=False versions of gatesets. - These gatesets are faster since they do not perform unitary decomposition to check equivalency. - Internal versions will switch to these versions once this change propagates.
dstrain115
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7693 +/- ##
========================================
Coverage 99.38% 99.38%
========================================
Files 1089 1089
Lines 97414 97531 +117
========================================
+ Hits 96812 96930 +118
+ Misses 602 601 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
times. This also avoids an isinstance check.
IdentityGate which is faster and more general.
decomposition to check equivalency.
propagates.